On Wed, 17 May 2023 13:09:09 GMT, Kevin Rushforth <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8091153: Improve javadoc to match the CSR
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.java
> line 472:
>
>> 470: *
>> 471: * @implNote This method can be overridden to create and show a
>> custom menu.
>> 472: * @param mouseEvent the {@link MouseEvent} which was generated
>> when the table menu button was pressed.
>
> Minor: by convention, the text following `@param` and `@return` tags should
> not end with a period.
Changed. And thanks for the hint, I actually didn't know that this is a
convention.
Personally, I also use the variant without a period, so it's good to know that
this is indeed the convention. 😄
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1135#discussion_r1196971714
