On Wed, 17 May 2023 19:29:13 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> This PR implements a way to override the table column menu. >> When the `cornerRegion` is pressed, it will now call the `showColumnMenu` >> method. This new method is protected and therefore can be overidden by >> developers. If not overridden, the known default column 'ContextMenu' is >> created and shown. >> >> This PR also resolves [JDK-8091419 >> ](https://bugs.openjdk.org/browse/JDK-8091419) (The method `showColumnMenu` >> can be overridden and made public now) >> >> This PR also helps with >> [JDK-8092148](https://bugs.openjdk.org/browse/JDK-8092148), but does not >> address all the points mentioned in the ticket. >> Now that everyone can provide their own implementation, we can think of >> treating the current implementation of the table column menu as an >> [MVP](https://en.wikipedia.org/wiki/Minimum_viable_product) and any other >> requested feature/idea should be fulfilled by providing your own >> implementaion of the menu. > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8091153: Added period to @implNote tested on macOS with Tree/TableView, working as expected. I wish the default implementation did not hide the popup on mouse click, to allow for toggling multiple columns, but it is out of scope for this PR. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1135#pullrequestreview-1431430131
