On Mon, 31 Jul 2023 17:30:16 GMT, Kevin Rushforth <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 990:
>>
>>> 988: */
>>> 989: public void play() {
>>> 990: Toolkit.getToolkit().checkFxUserThread();
>>
>> minor: perhaps this should first check for non-null parent, then for fx
>> thread (here and below)
>
> Our pattern everywhere else where we require the method to be called on the
> FX Application Thread is to do the thread check first.
I don't have a preference, but I see that this check is usually the first one
being performed, and then others (see for instance
`QuantumToolkit::enterNestedEventLoop`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1167#discussion_r1279666074
