On Mon, 31 Jul 2023 17:42:03 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> This PR adds a check to the Animation and AnimationTimer public methods to >> verify that these are called from the JavaFX Application thread. If the call >> is done from any other thread, an IllegalStateException will be thrown. >> >> This will prevent users from getting unexpected errors (typically NPE, like >> the one posted in the JBS issue), and will fail fast with a clear exception >> and reason for it. >> >> The javadoc of the Animation and AnimationTimer classes and public methods >> has been updated accordingly. >> >> Tests for both classes have been included, failing (as in no exceptions were >> thrown when calling from a background thread) before this patch, and passing >> (as in ISE was thrown). > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Removed extra lines looks good, thank you! ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1167#pullrequestreview-1555437591
