On Mon, 31 Jul 2023 17:34:20 GMT, Jose Pereda <jper...@openjdk.org> wrote:

>> Our pattern everywhere else where we require the method to be called on the 
>> FX Application Thread is to do the thread check first.
>
> I don't have a preference, but I see that this check is usually the first one 
> being performed, and then others (see for instance 
> `QuantumToolkit::enterNestedEventLoop`.

It's ok if this is done for historical reasons.  I would have expected the 
checks being done first on an entity of the innermost scope - the function 
argument, then progressively larger scope.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1167#discussion_r1279672371

Reply via email to