On Tue, 8 Aug 2023 23:44:58 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> So far, BorderPane does the calculation for the children min/pref >> width/height taken into account only the margin applied to them, if any, but >> not the total padding that could be applied as well to the BorderPane itself. >> >> However, this padding needs to be taken into account as well, and this PR >> modifies BorderPane to subtract its insets from its size while doing the >> children min/pref width/height calculations. >> >> A parameterized test has been included. >> >> It is a simplified version of the test case attached to >> https://bugs.openjdk.org/browse/JDK-8313709, but still shows how without >> this patch, two of the cases (padding with or without margin) fail, while >> pass with it. > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Migrate old tests to JUnit 5 FYI: the test code shows 2x2 arrangement on windows at 100%, but 1x4 arrangement at 125%. Is this expected? In both cases scrolling and resizing seems ok. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1203#issuecomment-1681333792
