On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Further changes to the MonkeyTester application: >> >> - remember split pane divider ✔ >> - use 'private' instead of 'protected' in many cases ✔ >> - added more scripts to the 'writing systems' text sample ✔ >> - added RTL window control menu ✔ >> - added embedded swing/fx in tools ✔ >> - added copy popup menu in clipboard viewer ✔ >> - added the custom css field to the css playground tool ✔ >> - added many new pages ✔ >> - split XYChartPage into separate pages ✔ >> - switched to use property sheets (some choices might be incomplete) ✔ >> >> https://github.com/andy-goryachev-oracle/jfx/blob/8316372.monkey/tests/manual/monkey/README.md >> >> These are all the changes I could make in this test sprint, other >> improvements will go to the follow-up ticket >> https://bugs.openjdk.org/browse/JDK-8328828 > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > spinner I have completed sanity testing all the pages. Added a comment inline. This change has added lot of options to the MT and it will be useful in testing the controls. Since you have already created a bug for next set of changes, I think this looks good for now. tests/manual/monkey/src/com/oracle/tools/fx/monkey/settings/FxSettingsSchema.java line 280: > 278: > 279: // FIX some kind of a bug, the dividers move slightly > each time > 280: sp.setDividerPositions(divs); Since we are calling this outside FX thread it won't throw exception in any scenario right? I checked and couldn't find anything. Wanted to make sure. ------------- PR Review: https://git.openjdk.org/jfx/pull/1406#pullrequestreview-1959880649 PR Review Comment: https://git.openjdk.org/jfx/pull/1406#discussion_r1538919751