On Tue, 26 Mar 2024 09:59:24 GMT, Karthik P K <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> spinner > > tests/manual/monkey/src/com/oracle/tools/fx/monkey/settings/FxSettingsSchema.java > line 280: > >> 278: >> 279: // FIX some kind of a bug, the dividers move slightly >> each time >> 280: sp.setDividerPositions(divs); > > Since we are calling this outside FX thread it won't throw exception in any > scenario right? I checked and couldn't find anything. Wanted to make sure. No, we are not calling this from outside the FX app thread. What happens here is that the resulting dividers are slightly off if we don't follow up with `Platform.runLater()`, and I am not sure why. I suspect this is a bug in SplitPane, but I can't easily come up with a SCCE. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1406#discussion_r1539855183
