On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv <d...@openjdk.org> wrote:

>> This change fixes the calculation of which nodes go to the toolbar and which 
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by 
>> ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the 
>> node is added to the scene graph.
>> 
>> Furthermore I corrected the ``hasOveflow`` value passed to the 
>> ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``.
>
> eduardsdv has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   JDK-8328577: Refactor and fix binding of style related properties

I can reproduce the behavior #1 in both versions before PR and after PR.

But I cannot reproduce the #2 and the #3 (may be I do not the necessary steps). 
Can you make a video or try to reproduce it the version before PR?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2066457533

Reply via email to