On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv <d...@openjdk.org> wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which >> go to the overflow menu. >> It is now determined before the nodes are removed from the scene graph. >> This is important because the values returned by >> ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the >> node is added to the scene graph. >> >> Furthermore I corrected the ``hasOveflow`` value passed to the >> ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``. > > eduardsdv has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8328577: Refactor and fix binding of style related properties I think these three issues are not related to this PR (even though the behavior seems to have changed a bit). I would look at this from the perspective of the keyboard-only user. Can they do everything they need to do, such as selecting/focusing/editing of the items in the toolbar as well as the overflow popup? (We might need to add a TextField and a CheckBox and maybe a ListView to the toolbar to verify that). If no function is impaired, we are ok. If the focus indicator (blue outlines etc) is wrong, or an item cannot be focused or some other function is broken, then we have an issue. What do you think? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2066880362
