On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv <d...@openjdk.org> wrote:

>> This change fixes the calculation of which nodes go to the toolbar and which 
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by 
>> ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the 
>> node is added to the scene graph.
>> 
>> Furthermore I corrected the ``hasOveflow`` value passed to the 
>> ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``.
>
> eduardsdv has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   JDK-8328577: Refactor and fix binding of style related properties

Marked as reviewed by kpk (Committer).

Created [JDK-8330859](https://bugs.openjdk.org/browse/JDK-8330859) for tracking 
focus handling issue in toolbar

-------------

PR Review: https://git.openjdk.org/jfx/pull/1434#pullrequestreview-2016271085
PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2071442595

Reply via email to