On Mon, 6 May 2024 08:24:52 GMT, drmarmac <d...@openjdk.org> wrote:

> This PR updates the javadoc for the SpinnerFactory wrap-around behavior 
> introduced in #1431.

modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactory.java
 line 417:

> 415:      * integer values.
> 416:      * <p>
> 417:      * If {@link #wrapAround} is {@code true}, the {@code 
> IntegerSpinnerValueFactory} will step from

The link for wrapAround does not resolve in Eclipse.
I'd suggest to change it to

* If {@link SpinnerValueFactory#wrapAround wrapAround}


Same comment applies to the min and max in line 420.

modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactory.java
 line 619:

> 617:      * double values.
> 618:      * <p>
> 619:      * If {@link #wrapAround} is {@code true}, the {@code 
> DoubleSpinnerValueFactory} will step through

wrapAround link does not resolve in Eclipse, see my earlier comment

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1450#discussion_r1591260910
PR Review Comment: https://git.openjdk.org/jfx/pull/1450#discussion_r1591264246

Reply via email to