On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp <d...@openjdk.org> wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` comparing the `maxLength` and `maxLength + start`. > > Oliver Kopp has updated the pull request incrementally with one additional > commit since the last revision: > > Streamline WinTextRangeProviderTest > > Source: > https://github.com/openjdk/jfx/pull/1442#pullrequestreview-2035329983 Marked as reviewed by arapte (Reviewer). >Thank you. I committed at >https://github.com/openjdk/jfx/commit/d03bdd40a3340bd85397fe2ceaa7f053a58da6c5 >(with you as author, hope this is in line with the policies?!). Thanks @koppor, the fix looks good. That's a great gesture, thanks, but I was just reviewing the changes, you don't have to add me as a contributor. Thanks for your contribution, Approving.! ------------- PR Review: https://git.openjdk.org/jfx/pull/1442#pullrequestreview-2042177454 PR Comment: https://git.openjdk.org/jfx/pull/1442#issuecomment-2097548737
