On Tue, 7 May 2024 18:46:26 GMT, Oliver Kopp <d...@openjdk.org> wrote:
>> We still want to use `assumeTrue` as the pattern (for flexibility), so the >> question is whether there is a better place besides a method annotated with >> `@BeforeAll` to put it (which also means duplicating the assumption in the >> `@AfterAll` method). I'm not aware of one, but maybe someone else is? > > My source: https://stackoverflow.com/q/30112317/873282, but I did totally > forget about `@AfterAll`. I was assuming that that would also have been > skipped if the `@BeforeAll` was skipped. 🙈 > > Think, for users coming from JUnit4, it is better to put the statements in > each test method, even though not executed. Junit 5 has an EnabledOnOs annotation https://junit.org/junit5/docs/5.2.0/api/org/junit/jupiter/api/condition/EnabledOnOs.html ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1592922258
