On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp <d...@openjdk.org> wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` comparing the `maxLength` and `maxLength + start`. > > Oliver Kopp has updated the pull request incrementally with one additional > commit since the last revision: > > Streamline WinTextRangeProviderTest > > Source: > https://github.com/openjdk/jfx/pull/1442#pullrequestreview-2035329983 The test gets an error on Mac and Linux. See inline comments. tests/system/src/test/java/test/com/sun/glass/ui/win/WinTextRangeProviderTest.java line 56: > 54: @AfterAll > 55: static void shutdown() { > 56: Util.shutdown(); This fails on Mac and Linux because the initialization (and consequently all tests) are skipped, but the call to `Util.shutdown` is not skipped. You will either need to also add `assumeTrue(PlatformUtil.isWindows());` here or else move the `assumeTrue` to the test method. ------------- Changes requested by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1442#pullrequestreview-2043673800 PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1592770104
