On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp <d...@openjdk.org> wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` comparing the `maxLength` and `maxLength + start`. > > Oliver Kopp has updated the pull request incrementally with one additional > commit since the last revision: > > Streamline WinTextRangeProviderTest > > Source: > https://github.com/openjdk/jfx/pull/1442#pullrequestreview-2035329983 The code changes look good to me; don't see any problems testing with Narrator on win11. I do have Deepl installed (though it is not connected due to proxy). See no issues in TextField, PasswordField, TextArea in the test app as well as the Monkey Tester. (once the tests are fixed, I'll re-approve) ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1442#pullrequestreview-2043926383
