On Thu, 20 Jun 2024 02:25:54 GMT, Jay Bhaskar <[email protected]> wrote:
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
The code changes in the modified files looks good. I confirm that the newly
added files match those same files in WebKit 616.1, accounting for the expected
changes in the current WebKit.
All my testing looks good.
I left a couple minor comments on the test. I've approved it, and will
re-approve after you update the test.
tests/manual/web/WebSocketTestApp.java line 2:
> 1: /*
> 2: * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights
> reserved.
This file is new in 2024, so you can remove the `2022,`
tests/manual/web/WebSocketTestApp.java line 62:
> 60: failButton.setOnAction(e -> {
> 61: Platform.exit();
> 62: throw new AssertionError("on paste the Data Nodes count is
> wrong.");
The error message is wrong. It looks like a copy/paste from another test
program. Something like "WebSocket connection failed" would be a better message.
-------------
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1477#pullrequestreview-2130763098
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1647771413
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1647773017
