On Thu, 20 Jun 2024 23:55:53 GMT, Jay Bhaskar <[email protected]> wrote:
>> Issue: The Websocket Channel is broken
>> Solution: The socket Provider needs a web page pointer, since the web socket
>> channel source code is moved to WebkitLegacy in 617.1 for the web process
>> model, it is invalid for JavaFx Webkit.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typos
tests/manual/web/WebSocketTestApp.java line 50:
> 48: new Label(" 1. Click on RunTest button"),
> 49: new Label(" "),
> 50: new Label(" 2. Expected behaviour: Data received from
> server meesgae should appear on webview"));
Typo: "meesgae" --> "message".
tests/manual/web/WebSocketTestApp.java line 62:
> 60: failButton.setOnAction(e -> {
> 61: Platform.exit();
> 62: throw new AssertionError("!Unable to receive meesgae data
> from server, something is wrong");
You fixed one of the two typos. "message" is still spelled wrong (as I
mentioned in my last comment). I found one other occurrence of that typo, so I
noted that as well.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1648268353
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1648268240
