On Wed, 16 Jul 2025 17:48:01 GMT, Andy Goryachev <[email protected]> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes for running apps in eclipse
>
> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLLog.java line 31:
>
>> 29:
>> 30: public class MTLLog {
>> 31: public static void Debug(String str) {
>
> Since `MTTLLog` is a home-grown facility:
>
> perhaps we should consider allowing `Supplier<String>` lambdas (or
> `Supplier<Object>`), or allow for `MessageFormat`'ted strings, to avoid
> concatenations.
>
> Lambdas may be faster, but they do require effectively final parameters.
The Log were helpful during development, but now it can be removed. Thanks for
pointing it out.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2223208606
