On Fri, 25 Jul 2025 15:50:35 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Merge branch 'master' into impl-metal >> - add comment for ES2SwapChain.getFboID >> - remove MTLLog >> - andy review comments 1 >> - changes for running apps in eclipse >> - review-update: jni method refactoring >> - add @Override >> - minor cleanup changes in glass >> - Use appropriate layer for setting opacity >> - Glass changes after Metal PR inputs >> - ... and 2 more: https://git.openjdk.org/jfx/compare/82a2f5ef...1a9a0a41 > > modules/javafx.graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/hw/MSLBackend.java > line 216: > >> 214: // For every user defined function, pass reference to 4 >> samplers and >> 215: // reference to the uniforms struct. >> 216: if >> (!CoreSymbols.getFunctions().contains(getFuncName(e.getFunction().getName())) >> && > > Eclipse kindly warns that `CoreSymbols.getFunctions()` is a collection of > `Function`, but it's searched of a `String`. Perhaps `.getName()` shouldn't > be called here? This means your Eclipse configuration differs from mine. Should we pull your configuration changes to this PR? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2231959256
