On Thu, 15 Jan 2026 17:17:48 GMT, Andy Goryachev <[email protected]> wrote:
>> Yes, but why not do the review and testing? We don't need to rush this >> change in, as there's no observable defect that's being fixed with this PR. > > having said that, I do agree with @mstr2 that sometimes it makes sense to do > a little unrelated cleanup when one touches a file, as long as it's safe and > obvious. but it is always met with arguments like "what if it needs to be > backported or creates a merge conflict" so it gets always shot down. I agree it seems better to limit the scope of this fix. I can certainly see the argument for expanding the fix to include the now-possibly-unnecessary try/catch (after all, removing one case where it is known to throw and thus be needed is what this fix does), but I'd rather keep the scope limited for this PR. As an off-topic note, I am opposed to cleaning up truly unrelated things that you just happen to notice while you are in the neighborhood, but Michael's request isn't this case. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2037#discussion_r2695337785
