On Wed, 18 Mar 2026 03:03:19 GMT, John Hendrikx <[email protected]> wrote:
>> This new check is much more accurate to detect whether a parent is currently >> laying out its children. The previous code almost never worked, resulting in >> additional unnecessary layouts. > > John Hendrikx has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge branch 'openjdk:master' into > feature/in-layoutchildren-detection-for-node > - Merge branch 'master' into feature/in-layoutchildren-detection-for-node > - Rename test > - Add regression test > - Fix ToolBarSkinTest > > Reusing a toolbar as part of several scenes, in combination with the > StubToolkit that doesn't handle pulses makes this test fail with the relayout > detection fix. > - Change how Node detects whether a relayout is required > > This new check is much more accurate to detect whether a parent is > currently laying out its children. The previous code almost never worked, > resulting in additional unnecessary layouts. > was this change included? #2007 ? I merge the latest master when reviewing any PR that's been out for too long, so yes. My concern is a high risk of regression (even if the regression is cosmetic): even if we fix this particular failure, other apps might fail in a similar fashion somewhere else. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1945#issuecomment-4083448309
