On Wed, 18 Mar 2026 03:03:19 GMT, John Hendrikx <[email protected]> wrote:
>> This new check is much more accurate to detect whether a parent is currently >> laying out its children. The previous code almost never worked, resulting in >> additional unnecessary layouts. > > John Hendrikx has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge branch 'openjdk:master' into > feature/in-layoutchildren-detection-for-node > - Merge branch 'master' into feature/in-layoutchildren-detection-for-node > - Rename test > - Add regression test > - Fix ToolBarSkinTest > > Reusing a toolbar as part of several scenes, in combination with the > StubToolkit that doesn't handle pulses makes this test fail with the relayout > detection fix. > - Change how Node detects whether a relayout is required > > This new check is much more accurate to detect whether a parent is > currently laying out its children. The previous code almost never worked, > resulting in additional unnecessary layouts. The `MenuBarSkin` basically just delegates to the `HBox`, making this even more weird. I wonder if the whole product here need to be snapped, not individually with `snappedLeftInset() + snappedRightInset()`. <img width="1049" height="91" alt="image" src="https://github.com/user-attachments/assets/254f393f-609b-47e7-959b-86edc7d051cf"; /> But since it works completely fine on Windows, it sounds like a problem somewhere else. I remember that there were some differences when the application is dragged onto another screen - Windows made one more relayout than MacOS or something? I think @beldenfox found something out there, but can't remember where it was. But I can only guess right now - once again need a Mac. :( ------------- PR Comment: https://git.openjdk.org/jfx/pull/1945#issuecomment-4663511915
