> This PR fixes the bug where list changes could be wrong (incorrect index). 
> Nearly everything was already in place, but one usecase that had a minor flaw.
> 
> Fix is simple, the index we use for iterating must be adjusted in case we 
> remove a change from `addRemoveChanges`.
> 
> All tests are green and I also added the Tests that were in the ticket. 
> Adjusted to JUnit 5 and with a bit of explaination which helped me a lot to 
> better understand the issue and fix it.

Marius Hanl has updated the pull request incrementally with one additional 
commit since the last revision:

  Add more assertions

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2117/files
  - new: https://git.openjdk.org/jfx/pull/2117/files/6f1ffc4e..8f586b04

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2117&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2117&range=00-01

  Stats: 25 lines in 1 file changed: 18 ins; 7 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/2117.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2117/head:pull/2117

PR: https://git.openjdk.org/jfx/pull/2117

Reply via email to