On Fri, 20 Mar 2026 17:28:43 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add more assertions
>
> modules/javafx.base/src/test/java/test/javafx/collections/ListChangeBuilderTest.java
> line 642:
>
>> 640: list.addListener((ListChangeListener.Change<? extends Integer>
>> change) -> {
>> 641: change.next();
>> 642: assertEquals(1, change.getRemovedSize());
>
> I wonder if instead of simply checking the size of the sub-arrays we could
> verify the exact content, which will test for size AND the order.
>
> Something like
>
> assertList(change.getRemoved(), 2);
>
> what do you think?
done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2117#discussion_r2967290397