On Fri, 20 Mar 2026 18:20:51 GMT, Marius Hanl <[email protected]> wrote:

>> This PR fixes the bug where list changes could be wrong (incorrect index). 
>> Nearly everything was already in place, but one usecase that had a minor 
>> flaw.
>> 
>> Fix is simple, the index we use for iterating must be adjusted in case we 
>> remove a change from `addRemoveChanges`.
>> 
>> All tests are green and I also added the Tests that were in the ticket. 
>> Adjusted to JUnit 5 and with a bit of explaination which helped me a lot to 
>> better understand the issue and fix it.
>
> Marius Hanl has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add more assertions

lgtm, thank you!

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2117#pullrequestreview-3983336271

Reply via email to