On Fri, 20 Mar 2026 01:25:15 GMT, Alexander Matveev <[email protected]> wrote:
> - Fixed potential NULL pointer dereference. > - Tested on all platforms with all supported media files. I code-reviewed the 8 changes you posted and all seems to be well, but I do have one question/suggestion. In all cases the NULL check happens under `GSTREAMER_LITE` define block. I didn't exactly find the reason why would that be needed, especially that these changes add a bunch of preprocessor variants to the code. I think we could just add the NULL checks without differentiating with-without `GSTREAMER_LITE` macro. Even if this will run on a platform where we are sure NULL cannot be returned and the check doesn't have sense it certainly won't hurt to have it, especially that some fixes refer to calls that can allocate memory - the NULL potential is always there if the machine runs out of RAM. This comment applies to all changes in this "NULL dereference" series, so this one and: * https://github.com/openjdk/jfx/pull/2113 * https://github.com/openjdk/jfx/pull/2114 * https://github.com/openjdk/jfx/pull/2116 * https://github.com/openjdk/jfx/pull/2120 * https://github.com/openjdk/jfx/pull/2121 * https://github.com/openjdk/jfx/pull/2122 * https://github.com/openjdk/jfx/pull/2123 ------------- PR Review: https://git.openjdk.org/jfx/pull/2115#pullrequestreview-3992316084
