On Tue, 24 Mar 2026 23:59:20 GMT, Alexander Matveev <[email protected]> wrote:
> > I code-reviewed the 8 changes you posted and all seems to be well, but I do > > have one question/suggestion. In all cases the NULL check happens under > > `GSTREAMER_LITE` define block. I didn't exactly find the reason why would > > that be needed, especially that these changes add a bunch of preprocessor > > variants to the code. > > When we do changes in GStreamer/GLib/libFFI we enclosed them in > `GSTREAMER_LITE` define block to differentiate any our changes to these > libraries from original source code. In this case it is easy to merge changes > from GStreamer/GLib/libFFI upstream without overwriting our changes. Ah, that explains it, I had no idea. All good then. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2115#issuecomment-4126372760
