On Fri, 20 Mar 2026 01:25:15 GMT, Alexander Matveev <[email protected]> wrote:
> - Fixed potential NULL pointer dereference. > - Tested on all platforms with all supported media files. I was also curious about the use of conditional compilation. And I have a few other questions. - Most of the fixes seem to be in third-party libraries. Shouldn't the fixes be applied upstream of JavaFX so we don't have to maintain them locally as we update the libraries? - Which of these fixes are related to recovering from a memory out condition? The last time this came up I did some digging around and discovered that desktop operating systems almost never return NULL from malloc even when memory is exhausted. Linux and macOS use an overcommit strategy which defers the error to the first time you access the memory at which point the process is unconditionally killed. Windows is more complicated but I recall null checks aren't very effective there either; by the time you see NULL the process is in a state where recovery is almost impossible. - Is it the policy of JavaFX to check for and recover from memory out conditions? Again, I'm not sure any OS will allow us to do that but in any case updating the entire codebase to recover correctly would be a huge undertaking and probably pointless unless we create a matching testing environment. - Is there something specific to gstreamer that warrants adding checks to this one subsystem? ------------- PR Comment: https://git.openjdk.org/jfx/pull/2115#issuecomment-4112033820
