On Sat, 16 May 2026 07:36:18 GMT, Michael Strauß <[email protected]> wrote:

> The EffectPeer instances were disposed, but not removed from the map

Yes, that is what I mean. But is there any side effect we may have now that we 
remove those entries from the map?

If I understand you right, synchronization is the reason you chose to not do?:


 for (EffectPeer<?> peer : peerCache.values()) {
    peer.dispose();
}
peerCache.clear();


Because this would save us the temp array and is a bit easier too.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2091#discussion_r3252747928

Reply via email to