On Mon, 2 Mar 2026 22:14:15 GMT, Michael Strauß <[email protected]> wrote:
>> The current implementation of `Renderer.getPeerInstance()` looks up mappings >> by concatenating strings to form a combined key: >> >> peer = peerCache.get(name + "_" + unrollCount); >> >> >> This can be improved by not using strings to store the combined key, but >> using a simple `PeerCacheKey` class instead. >> The `Renderer` class then uses a single reusable `PeerCacheKey` object to >> look up mappings, making the lookup allocation-free. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > review comment It feels like my concerns about synchronization were not properly addressed. Also, the use of mutable key (which might be ok in this particular case, hope there is no chance for re-entry), but this design is - let's say - unorthodox, might have created a booby trap. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2091#issuecomment-4478767148
