On Sat, 16 May 2026 12:41:01 GMT, Marius Hanl <[email protected]> wrote:
>> This is a follow-up to the combobox converter PR. It seems like the >> updateDisplayNode method in the Skin does not properly handle null cases for >> when null is an item in the combobox. It probably incorrectly assumes that >> any null values is mapped to null by the stringconverter. However, if you >> create a custom converter, a null value can have a non-null string value. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxListViewSkin.java > line 366: > >> 364: // exist in the ComboBox items list (part two of fix) >> 365: if (index > -1) { >> 366: buttonCell.setItem(null); > > Is this even needed? Because when we update the index anyway below, we are > usually also setting the item? I am not sure, I just kept the original semantics. Maybe there was a reason why it did it like this ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2169#discussion_r3252811376
