> This is a follow-up to the combobox converter PR. It seems like the 
> updateDisplayNode method in the Skin does not properly handle null cases for 
> when null is an item in the combobox. It probably incorrectly assumes that 
> any null values is mapped to null by the stringconverter. However, if you 
> create a custom converter, a null value can have a non-null string value.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Christopher Schnick has updated the pull request incrementally with one 
additional commit since the last revision:

  Move setItem call

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2169/files
  - new: https://git.openjdk.org/jfx/pull/2169/files/fd34a158..5712360a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2169&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2169&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/2169.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2169/head:pull/2169

PR: https://git.openjdk.org/jfx/pull/2169

Reply via email to