On Tue, 19 May 2026 21:43:02 GMT, Andy Goryachev <[email protected]> wrote:
>> Christopher Schnick has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move setItem call > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxListViewSkin.java > line 375: > >> 373: buttonCell.pseudoClassStateChanged(PSEUDO_CLASS_EMPTY, >> empty); >> 374: buttonCell.pseudoClassStateChanged(PSEUDO_CLASS_FILLED, >> !empty); >> 375: buttonCell.pseudoClassStateChanged(PSEUDO_CLASS_SELECTED, >> true); > > this is not exactly an equivalent change, since we are updating pseudostyles > (esp. PSEUDO_CLASS_SELECTED, true). is it important? probably not: we'll > end up with pseudostyles set on something not connected to the scene graph, > probably not a big deal. This should correct as that is related to the problem. When you select a value, the empty pseudo style class should always update. It previously did not do that in all cases like when the value was null but the converted string was not null. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2169#discussion_r3271362346
