On Tue, 16 Jun 2026 21:03:00 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 194 commits: >> >> - test standard attributes >> - Merge branch 'master' into 8356042.ruler >> - ws >> - test doc props >> - cleanup >> - tab stops >> - Merge branch 'master' into 8356042.ruler >> - renamed doc >> - docs >> - Merge branch 'master' into 8356042.ruler >> - ... and 184 more: https://git.openjdk.org/jfx/compare/738be0f1...87241d12 > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/RichTextModel.java > line 56: > >> 54: * @since 27 >> 55: */ >> 56: public static final double DEFAULT_TAB_STOPS_8 = 0.0; > > When I suggested using named static final fields (constants), I hadn't > realized that this was a floating-point attribute. It still seems OK to do > this, but we should be careful checking for equality (other than equality > with 0). > > I don't much care for the use of `8` in the name. That seems odd. Maybe > `DEFAULT_TAB_STOPS_FIXED` or similar? FIXED is good, thanks! ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1800#discussion_r3424295519
