On Tue, 16 Jun 2026 22:06:35 GMT, Andy Goryachev <[email protected]> wrote:
>> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/RichTextFormatHandler.java >> line 544: >> >>> 542: index += 2; >>> 543: // TODO check if already exists >>> 544: String ver = parseString(); >> >> In order for it to be effective, the version needs to be the first thing in >> the file in addition to there being only one of them (and it eventually >> needs to be mandatory). I'm still not sold on treating the version string as >> "just another section", but at a minimum, you need to check whether this is >> the first thing seen (not just the first version block), and fail if it >> isn't. > > It is sort of byproduct of the serialization mechanism, in a sense that it > emits a series of well-defined segments. I suspect we might need to revisit > the overall scheme once most of the requested attributes are in, and perhaps > to change the way the model is being serialized altogether (for example, > provide a more efficient binary format). > > I'd like to leave this until later, with your permission. Later is fine. Make sure we have a follow-on bug for it. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1800#discussion_r3424403679
