On Tue, 16 Jun 2026 23:17:44 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyledTextModel.java
> line 554:
>
>> 552: * @since 27
>> 553: */
>> 554: protected String versionString() {
>
> I don't understand why this is declared here in StyledTextModel, but not
> actually defined as a useful (non-null) value except in the RichTextModel
> subclass. This is another thing to add to the follow-up to figure out how
> version should be exposed in the API.
The main idea here is that the StyledTextModel handles the export, so it must
know how to decompose the content into a series of `StyledSegment` fragments to
be consumed by `StyledInput`.
The model may not have the version or the document properties (a view-only
model, for instance), but the base class knows how to deal with it if these
things are present.
But I do get your point about the follow-up, so I filed
https://bugs.openjdk.org/browse/JDK-8386850
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1800#discussion_r3430328044
