On Mon, 22 Jun 2026 12:54:40 GMT, Marius Hanl <[email protected]> wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added new getPromptNode() method to TextInputSkinShim
>
> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/TextInputControlModenaTest.java
> line 152:
>
>> 150:
>> 151: try {
>> 152:
>> Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);
>
> Why is that done here? Never saw it before so I just removed it locally and
> the test still pass and fails without the fix.
Ok I think I know what may was going on.
There is another test that will not correctly reset the application user agent
stylesheet.
I created https://bugs.openjdk.org/browse/JDK-8387020 with more details and
will create a PR soon.
So in my opinion, we should remove
`Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);` because it
will actually hide if another test incorrectly resets the user agent stylesheet.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2184#discussion_r3452450931
