On Mon, 22 Jun 2026 13:10:59 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/TextInputControlModenaTest.java
>> line 152:
>>
>>> 150:
>>> 151: try {
>>> 152:
>>> Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);
>>
>> Why is that done here? Never saw it before so I just removed it locally and
>> the test still pass and fails without the fix.
>
> Ok I think I know what may was going on.
>
> There is another test that will not correctly reset the application user
> agent stylesheet.
> I created https://bugs.openjdk.org/browse/JDK-8387020 with more details and
> will create a PR ~soon~. done.
>
> In my opinion, we should remove
> `Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);` here,
> because for one, it's the default anyway, and if another test incorrectly
> sets the user-agent stylesheet, this test shouldn't hide that - it should
> fail.
I think this is good as is - the bug calls for Modena.css specifically, so the
test ensures the right stylesheet.
And thanks for filing JDK-8387020 - it is indeed a weird choice of data url.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2184#discussion_r3452941949
