On Mon, 22 Jun 2026 17:59:05 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Yes correct. >> >> But what I mean is that the preexisting test >> `TextInputControlModenaTest#testHighlightTextInput` failed as well without >> JDK-8387020. >> And this test does not set the modena stylesheet with >> `Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);` but >> should do as well because it will fail if another stylesheet is used >> tomorrow. >> >> Thats why I propose to either remove >> `Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);` or set >> it in an `@BeforeEach` method - here in `TextInputControlModenaTest` and >> reset in an `@AfterEach`, because not just this new test depends on modena, >> but the existing one does as well. > > But a false cleanup from another test (in this case the test mentioned in > JDK-8387020) that changes the Application user agent stylesheet value doesn't > really mean that our test should fail no ? as it is a wrong implementation i > guess in the that test. I tried it too and yes > `TextInputControlModenaTest#testHighlightTextInput` fails without > JDK-8387020 as it uses the previous value. Maybe with that new fix it is fine > to remove `Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);` Right, either - remove: `Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);` from here - or add it to the `TextInputControlModenaTest#testHighlightTextInput` test (or better in `@BeforeEach` with a reset in `@AfterEach`, so it will run for all tests in `TextInputControlModenaTest` now and in the future) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2184#discussion_r3454613627
