On Fri, 10 Jul 2026 11:47:01 GMT, John Hendrikx <[email protected]> wrote:

>> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerManager.java
>>  line 165:
>> 
>>> 163:                 setData(instance, list.getInvalidationListener(0));
>>> 164:             }
>>> 165:             else if (changeListenersSize == 1) {
>> 
>> ... it must be your style, but it throws my pattern recognition.  if no one 
>> else objects, you can ignore my pain.
>
> It is indeed the style I use, so you'll see this a lot indeed :)  Let's focus 
> on the implementation first I'd say, you brought up some good points already 
> that I will dive deeper into before answering.

I would also prefer the `} else if (..) {` style. 
+1 to focus on the implementation regardless.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r3558881365

Reply via email to