On Thu, 9 Jul 2026 18:29:56 GMT, Andy Goryachev <[email protected]> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix flakey check on (asynchronous) stderr output
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ArrayManager.java 
> line 315:
> 
>> 313:      * completes.<p>
>> 314:      *
>> 315:      * Note: it is not allowed to change the array fields during this 
>> call;
> 
> minor: "array fields" is a bit confusing.  array elements?

I'll update this to be more clear; fields is correct, but what I meant is: 
during compaction, don't call `setArray` or `setOccupiedSlots`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r3558951254

Reply via email to