On Thu, 9 Jul 2026 17:16:22 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix flakey check on (asynchronous) stderr output
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ArrayManager.java
> line 284:
>
>> 282: else if (shift > 0) {
>> 283: array[i - shift] = array[i];
>> 284: array[i] = null;
>
> this nulls unused elements only when `shift>0`. what happens if the unused
> element are at the end? I think they will remain strongly referenced via
> `array[]`.
You're correct. I've modified this to do an `Arrays.fill` if there was anything
shifted.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r3561732804
