On Fri, 14 Aug 2026 04:48:24 GMT, Alexander Zuev <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java
>> line 809:
>>
>>> 807: * <li>Used by: ListView and TableView </li>
>>> 808: * <li>Needs notify: no </li>
>>> 809: * <li>Return Type: {@code int[]} containing the first item index
>>> and the
>>
>> please specify how it encodes a no-range case.
>>
>> it looks like the code returns [0,0], but is this right?
>> should it return an empty array or `null` instead?
>
> The {0, 0} is the valid range, we should not return empty array or null in
> any case.
this exceptional case needs to be documented.
>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java
>> line 811:
>>
>>> 809: * <li>Return Type: {@code int[]} containing the first item index
>>> and the
>>> 810: * number of visible items </li>
>>> 811: * <li>Parameters: </li>
>>
>> Parameters: should describe the structure (see `BOUNDS_FOR_RANGE` for
>> example)
>
> We do not pass any parameters to the VISIBLE_ITEM_RANGE property so the
> parameters list should be empty.
what do you mean?
https://github.com/openjdk/jfx/pull/2217/changes#diff-bdee521c329d386e86fab0d6870c31750481dddb7cb5ca6aa65854948ca649f8R379
we must document the parameters (and exceptional cases like no visible range).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3797199260
PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3797196797
