On Wed, 15 Jul 2026 14:01:15 GMT, Marius Hanl <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/NodeHelper.java 
>> line 150:
>> 
>>> 148:      * @return the styleClass or null
>>> 149:      */
>>> 150:     public static List<String> getStyleClassOrNull(Node node) {
>> 
>> Most (all?) helper classes that implement the private accessor pattern don't 
>> have documentation, because it is implied that it's a simple forwarding 
>> method.
>
> My thought was to explain why this method exists. Do you have a suggestion, 
> or should we just remove it entirely?

I don't think that accessor methods should contain specification (that should 
probably live on the actual implementation), but you decide if you want to keep 
it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2191#discussion_r3791450991

Reply via email to