On Mon, 7 Sep 2026 13:02:35 GMT, Michael Strauß <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8386663-Stylesheet/StyleClass-list-should-be-lazily-initialized >> - remove doc >> - review comments >> - improve tests >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8386663-Stylesheet/StyleClass-list-should-be-lazily-initialized >> - MenuItem toString() should also use the new styleClass way. >> >> TwoLevelFocusListBehavior was very weirdly relying on the toString() >> behavior >> - Move styleClass.toString into Node.toString() >> - 8386663: Stylesheet/StyleClass list should be lazily initialized > > modules/javafx.controls/src/main/java/javafx/scene/control/MenuItem.java line > 641: > >> 639: else sbuf.append(", "); >> 640: sbuf.append("styleClass="); >> 641: for (int i = 0; i < getStyleClass().size(); i++) { > > You could replace all of that with `String.join(" ", getStyleClass())`. good idea, done. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2191#discussion_r3950112678
