On Mon, 31 Aug 2026 11:47:00 GMT, Michael Strauß <[email protected]> wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/RegionTest.java >> line 2529: >> >>> 2527: Arguments.of(1.25, 1.25), >>> 2528: Arguments.of(1.5, 1.5), >>> 2529: Arguments.of(2.5, 2.5), >> >> I recommend including the following scales here and in the other snapping >> PRs: >> >> 1.0, 1.25, 1.5, 1.75, 2.0, 2.25 >> >> <img width="326" height="322" alt="Screenshot 2026-08-28 135323" >> src="https://github.com/user-attachments/assets/27676d2b-b204-469a-b6c8-d828e46b44d4"; >> /> > > I've added 2.0 and 2.25, so now all render scales are included. something is wrong, the list is incomplete. suggestion: Arguments.of(1.0, 1.0), Arguments.of(1.25, 1.25), Arguments.of(1.5, 1.5), Arguments.of(1.75, 1.75), Arguments.of(2.0, 2.0), Arguments.of(2.25, 2.25), followed by the mismatched values as before ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2278#discussion_r3898111357
