On Fri, 28 Aug 2026 22:58:02 GMT, Andy Goryachev <[email protected]> wrote:

>> Michael Strauß has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   more render scales
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line 
> 439:
> 
>> 437:      */
>> 438:     private static double snapAligned(double value, boolean 
>> snapToPixel, double snapScale) {
>> 439:         return snapToPixel ? ScaledMath.round(value, snapScale) : value;
> 
> does this method expects `Double.MAX_VALUE`?  what would happen?

Like the other methods, it would snap the value to the pixel grid, which is not 
the same as `Double.MAX_VALUE`. If that particular value is treated as a 
sentinel by the caller, then it's probably the responsibility of the caller to 
ensure that it isn't passed into the snapping methods.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2278#discussion_r3894161436

Reply via email to