On Mon, 31 Aug 2026 22:22:12 GMT, Andy Goryachev <[email protected]> wrote:
> * The implementation leverages the software Pisces renderer.
> * This lays the groundwork for future support of text rendering and path
> operations.
>
> aren't these already implemented in this version? or something is still
> missing?
Right, I'll remove that -- that was before I finished the PoC.
> modules/javafx.graphics/src/main/java/javafx/scene/canvas/GraphicsContext.java
> line 1501:
>
>> 1499: }
>> 1500:
>> 1501: @Override
>
> is this a new method in the `GraphicsContext`? if so, it needs `@since`.
Ah, yes, it is; as the SW rendered can't do arbitrary clips, but rectangular
clips are still useful, I added this method as a compromise.
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/geom/Path2DTest.java
> line 209:
>
>> 207: }
>> 208: }
>> 209: RectBounds rectBounds = new RectBounds(10, 20, 20, 30);
>
> seems unrelated, but I would rather clean up this unused code.
you're right, it just annoys me when files have warnings, as I can't see as
easily if the files I'm committing are warning free then :)
> modules/javafx.graphics/src/test/java/test/com/sun/prism/sw/SWDrawingContextTest.java
> line 89:
>
>> 87: }
>> 88: catch (Exception e) {
>> 89: throw new IllegalStateException(e);
>
> illegal state? is this the right exception for the occasion?
It hardly matters, this is test code. I use `IllegalStateException` for things
that can't happen (which is the case here).
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1969#issuecomment-5485919659
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3899157992
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3899166229
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3899169271
