On Tue, 1 Sep 2026 18:37:56 GMT, Andy Goryachev <[email protected]> wrote:
>> It hardly matters, this is test code. I use `IllegalStateException` for >> things that can't happen (which is the case here). > > good point, but maybe `throw new AssertionError(e);` instead (as in > BorderTest:588) I've removed this... it turns that by calling `Screen.getMainScreen()` it tries to get a screen, which would fail in tests since there were no screens... but we don't use the screen at all in the software renderer... so just by calling `Screen.getMainScreen()` we created this unnecessary dependency. `SWDrawingContext` now just leaves the screen `null` as it doesn't need it, and I added a bit of documentation on `SWResourceFactory` to explain that `getScreen` might be `null` instead. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3940458904
